-
Notifications
You must be signed in to change notification settings - Fork 421
feat(event_source): add class APIGatewayAuthorizerResponseWebSocket #6058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6058 +/- ##
===========================================
+ Coverage 96.24% 96.25% +0.01%
===========================================
Files 234 234
Lines 11024 11057 +33
Branches 800 803 +3
===========================================
+ Hits 10610 10643 +33
Misses 327 327
Partials 87 87 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR! Thank you Leo, approved
|
…ws-powertools#6058) * Adding new class to WebSocket Authorizer * Adding new class to WebSocket Authorizer * Making mypy happy * Making mypy happy --------- Co-authored-by: Ana Falcão <[email protected]>
Issue number: #5800
Summary
Changes
The current
APIGatewayAuthorizerResponse
class is not suitable for generating valid policy statements for WebSocket APIs. This new class will ensure that developers can easily create correct authorization responses for WebSocket APIs.The new
APIGatewayAuthorizerResponseWebSocket
class address the limitations of the currentAPIGatewayAuthorizerResponse
class when dealing with WebSocket APIs. The existingallow_route()
,deny_route()
,deny_all_routes
andallow_all_routes()
methods do not create valid policy statements for WebSocket connections, necessitating a separate class to handle WebSocket-specific authorization responses.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.